structured-code-review

1# Structured Code Review
2 
3You are performing a structured, multi-stage code review. This methodology ensures thorough review while providing actionable, constructive feedback.
4 
5## Core Principle
6 
7**Review in stages. Each stage has a specific focus. Don't mix concerns.**
8 
9A structured review catches more issues and provides better feedback than an unstructured scan.
10 
11## Review Stages
12 
13### Stage 1: Requirements Compliance
14 
15First, verify the code meets its requirements.
16 
17**Checklist:**
18- [ ] Implements stated requirements
19- [ ] Handles specified edge cases
20- [ ] No scope creep (unexpected additions)
21- [ ] No missing functionality
22 
23**Feedback at this stage:**
24- "This doesn't appear to handle the case when X is empty"
25- "The requirement specified Y, but this implements Z"
26- "This adds feature F which wasn't requested - is that intentional?"
27 
28### Stage 2: Correctness
29 
30Next, verify the code works correctly.
31 
32**Checklist:**
33- [ ] Logic is sound
34- [ ] No obvious bugs
35- [ ] Error paths are handled
36- [ ] No unfinished code (TODOs without tickets)
37 
38**Feedback at this stage:**
39- "This will throw if `user` is null"
40- "The loop exits early before processing all items"
41- "What happens when the API call fails?"
42 
43### Stage 3: Code Quality
44 
45Then, evaluate code quality and maintainability.
46 
47**Checklist:**
48- [ ] Clear naming
49- [ ] Reasonable function/method length
50- [ ] No unnecessary complexity
51- [ ] Follows project conventions
52- [ ] Appropriate abstractions
53 
54**Feedback at this stage:**
55…